Merged
Conversation
Closed
zeebok
approved these changes
Sep 18, 2025
Contributor
zeebok
left a comment
zeebok
left a comment
There was a problem hiding this comment.
There are conflicts so I haven't tested but this code looks good to me.
ryonakano
reviewed
Sep 18, 2025
# Conflicts fixed: # libcore/FileUtils.vala
ryonakano
reviewed
Sep 21, 2025
Remove leftover code Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
Remove extraneous space Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
Remove extraneous space Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
ryonakano
approved these changes
Sep 22, 2025
Member
ryonakano
left a comment
ryonakano
left a comment
There was a problem hiding this comment.
Leaving one optional comment but otherwise LGTM and works as expected.
src/View/Widgets/AppMenu.vala
Outdated
| locale_button.get_style_context ().add_class (Gtk.STYLE_CLASS_MENUITEM); | ||
| var informal_button = new Gtk.RadioButton.with_label_from_widget (iso_button, DateFormatMode.INFORMAL.to_string ()); | ||
| informal_button.get_style_context ().add_class (Gtk.STYLE_CLASS_MENUITEM); | ||
| //TODO Add a custom format wizard? Or a detailed informat format? Or "days ago" format? |
Member
There was a problem hiding this comment.
I think we should simply remove this TODO and file an issue if we won't address it in this PR but really want to in the future. TODO comments are often buried in projects that have many source codes and are developed by multiple developers.
Contributor
Author
There was a problem hiding this comment.
OK, I've now limited this PR to exposing the setting. We can consider other formats later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any setting that is actively supported should be accessible through the UI. A user could have reason to change the datetime format for a particular folder/purpose.
For now, the existing three options are exposed as radiobuttons appended to the AppMenu.