Do not unquote dropped and pasted uris from uri_list#2638
Merged
Conversation
zeebok
approved these changes
Aug 27, 2025
Contributor
zeebok
left a comment
zeebok
left a comment
There was a problem hiding this comment.
Seems to work as intended
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2637
Simplest fix for the linked issue.
Files not longer quotes uris for dropping into apps like Terminal - the destination must do any quoting themselves. We can assume other apps behave similarly and we do not need to unquote received uris.
Note that since a single quote is one of the characters in
GLib.RESERVED_CHARS_SUBCOMPONENT_DELIMITERSit does not get escaped in uris when files are being drag/dropped - but that is not changed by this PR.Reviewers should confirm that under no circumstances do we need to unquote.