Skip to content

Systemd optional#2768

Merged
jeremypw merged 1 commit intomainfrom
jeremypw/systemd-optional
Mar 2, 2026
Merged

Systemd optional#2768
jeremypw merged 1 commit intomainfrom
jeremypw/systemd-optional

Conversation

@jeremypw
Copy link
Contributor

@jeremypw jeremypw commented Mar 2, 2026

Systemd dependency is not required so build should not fail if it is absent.

In main the systemd dependency is marked as optional but is followed by an assert that it must be found which seems contradictory.

With this PR absence of the systemd dependency has the same effect as building with the option 'systemduserunitdir' set to 'no' .

For some reason the development-target CI was failing to find the systemd dependency. Is this expected? With this PR the development target CI passes.

@jeremypw jeremypw requested a review from a team March 2, 2026 15:59
@jeremypw jeremypw marked this pull request as ready for review March 2, 2026 16:00
@danirabbit
Copy link
Member

danirabbit commented Mar 2, 2026

I think this is fine but we should also add systemd-dev to CI. It seems like it's because of package renames that wasn't building for Resolute.

Also worth noting that we require systemd for the session itself now, so if it's a burden for you to maintain optional systemd support, I don't think it would be unreasonable to just require it

@jeremypw
Copy link
Contributor Author

jeremypw commented Mar 2, 2026

@danirabbit Yes, this was just a quick fix. I am not entirely sure what the systemd stuff does but since it was marked "not required" and there is a build option to disable it I assumed it wasn't essential. Presumably the FileChooser portal will still work without it? It won't affect elementary anyway since we ship systemd. I doubt Files is used on non-systemd systems that much.

@jeremypw jeremypw merged commit d0f6f8d into main Mar 2, 2026
4 checks passed
@jeremypw jeremypw deleted the jeremypw/systemd-optional branch March 2, 2026 17:37
@danirabbit
Copy link
Member

Ah that's probably what it is, the portal probably requires systemd to run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants