Conversation
|
I think this is fine but we should also add Also worth noting that we require systemd for the session itself now, so if it's a burden for you to maintain optional systemd support, I don't think it would be unreasonable to just require it |
|
@danirabbit Yes, this was just a quick fix. I am not entirely sure what the systemd stuff does but since it was marked "not required" and there is a build option to disable it I assumed it wasn't essential. Presumably the FileChooser portal will still work without it? It won't affect elementary anyway since we ship systemd. I doubt Files is used on non-systemd systems that much. |
|
Ah that's probably what it is, the portal probably requires systemd to run |
Systemd dependency is not required so build should not fail if it is absent.
In
mainthe systemd dependency is marked as optional but is followed by an assert that it must be found which seems contradictory.With this PR absence of the systemd dependency has the same effect as building with the option
'systemduserunitdir'set to'no'.For some reason the
development-targetCI was failing to find thesystemddependency. Is this expected? With this PR the development target CI passes.