Skip to content

Consider sector size for ESP and reduce minimum size required#449

Closed
vjr wants to merge 14 commits intoelementary:masterfrom
vjr:esp-sector-size
Closed

Consider sector size for ESP and reduce minimum size required#449
vjr wants to merge 14 commits intoelementary:masterfrom
vjr:esp-sector-size

Conversation

@vjr
Copy link
Copy Markdown
Member

@vjr vjr commented Sep 12, 2020

Fixes #446 Addresses #448

If this is approved, supersedes #447 which won't need to be merged.

@davidmhewitt
Copy link
Copy Markdown
Member

davidmhewitt commented Jan 22, 2021

After some experimenting relating to fixing installations performed with encryption enabled, it turns out distinst enforces a minimum ESP size (measured in sectors 😱 ), so if this was merged, it wouldn't work EFI sizes less than 256 MiB (on a 512 byte sector disk) anyway.

https://github.com/pop-os/distinst/blob/30ac4051febf1847f732de7e25261c869a852741/crates/disks/src/config/disks.rs#L981

@vjr
Copy link
Copy Markdown
Member Author

vjr commented Jan 23, 2021

I've filed pop-os/distinst#239 in the hope that something can be worked out for us Windows users :-)

@vjr vjr closed this Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installer minimum required EFI partition size is too large

4 participants