Prepare support for other backends#737
Merged
meisenzahl merged 33 commits intomainfrom Oct 3, 2024
Merged
Conversation
instead of Distinst
bootloader_detect method
…on and ProgressView
…emon.Daemon signals
…se in a default statement.
6e40a64 to
aab202c
Compare
This reverts commit aab202c.
Member
Author
|
I successfully tested this with elementaryos-8.0-daily.20240925.iso. Steps to test this
|
danirabbit
reviewed
Oct 1, 2024
danirabbit
requested changes
Oct 1, 2024
Member
|
@meisenzahl Would it be too much to ask to propose the hostname validator bit as a separate branch? I think that's probably worth its own commit |
Merged
danirabbit
approved these changes
Oct 2, 2024
Member
danirabbit
left a comment
There was a problem hiding this comment.
This looks good to me! I can confirm that the new DistinstBackend file is basically what was in Daemon plus a few methods to convert from Distinst structs to our internal structs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This serves as preparation to be able to support other installer backends.