Skip to content

ProcessInfoView: handle process actions#484

Merged
stsdc merged 8 commits intomainfrom
danirabbit/process-actions
Oct 8, 2025
Merged

ProcessInfoView: handle process actions#484
stsdc merged 8 commits intomainfrom
danirabbit/process-actions

Conversation

@danirabbit
Copy link
Member

I'm not sure why this isn't working. Buttons work with the action name and still show accel labels, so acecls are being set 🤷‍♀️

@danirabbit danirabbit mentioned this pull request Oct 7, 2025
3 tasks
@danirabbit danirabbit moved this to In progress in OS 8.1.0 Oct 7, 2025
@stsdc
Copy link
Member

stsdc commented Oct 8, 2025

The kill_action.activate.connect is not being triggered at all.

@danirabbit
Copy link
Member Author

@stsdc actions seem to be working as expected here when you press the button. Manually activating from the inspector also works here. And get_accels_for_action is returning the correct shortcut. So I have no idea why it's not actually working. My guess is that something is swallowing the shortcut, but I don't know what

@danirabbit
Copy link
Member Author

@stsdc it's not clear to me why this isn't working with set_accels but I got it working with a key controller 🤷

@danirabbit danirabbit marked this pull request as ready for review October 8, 2025 19:14
@danirabbit danirabbit requested a review from a team October 8, 2025 19:14
@stsdc
Copy link
Member

stsdc commented Oct 8, 2025

Works. But it also works on root processes 😬 We want to prevent the confirmation dialog to show up on this kind of processes. In the future, we need to show a notification that explains this. I have created an issue about that.

image

@danirabbit
Copy link
Member Author

Ah yeah that's not a super difficult fix. Just have to disable the action. One second

@danirabbit
Copy link
Member Author

@stsdc should be fixed. Thanks for testing thoroughly!

@stsdc stsdc merged commit 9617e66 into main Oct 8, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in OS 8.1.0 Oct 8, 2025
@stsdc stsdc deleted the danirabbit/process-actions branch October 8, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants