Add xvfb to dependencies in README.md#502
Add xvfb to dependencies in README.md#502stsdc merged 3 commits intoelementary:mainfrom Tbusk:patch/readme-dependencies
xvfb to dependencies in README.md#502Conversation
|
But this is a test dependency right? |
|
Perhaps, although, the particular dependency seems to force its usage upstream to this project due to it being set as default. Meaning if any tests are ran in this repo, it forces it to be wrapped by the Should it get its own section @stsdc ? |
|
I mean we can add this, but i think the real problem is that we can't disable live-chart tests. I think it would be nice to find some solution to that. But if there is no solution, I approve anyway. |
|
Are you referring to in the CI, specifically the commented out test lines here @stsdc? https://github.com/elementary/monitor/blob/main/.github/workflows/ci.yml If so, yeah, that is easy to get around. Although I did run into an issue where all my tests were being wrapped in Then all you need to do is (at least for now) modify it to run the specific test (and perhaps a test suite later on) https://mesonbuild.com/Unit-tests.html meson test -C build monitor-statusbar-testAnd the test would result in this (once the typo/gtk init signature change is fixed in the test): |
|
yeah. Then, let's create a separate workflow for test purposes and isolate Monitor's tests there. |

Closes #501
This PR adds
xvfbto the list of dependencies in the readme.