Skip to content

Allow to disable nvidia libraries #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stsdc merged 8 commits into from
Jan 23, 2026
Merged

Allow to disable nvidia libraries #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7d381d8
Remove nVidia support when building on aarch64 Alpine
stsdc Jan 9, 2026
6093368
Rename option to "nvidia support"
stsdc Jan 18, 2026
9ecd619
Update readme
stsdc Jan 18, 2026
9863fd4
Update src/Resources/GPU/GPUNvidia.vala
stsdc Jan 19, 2026
5b99a52
Update src/Resources/GPU/GPUNvidia.vala
stsdc Jan 19, 2026
0209927
Fix comment; remove newlines
stsdc Jan 19, 2026
48a55ac
Comment update
stsdc Jan 22, 2026
5f0e047
Merge branch 'main' into alpine-aarch64
stsdc Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,13 @@ vapidir = meson.current_source_dir() / 'vapi/'

add_global_arguments('-DGETTEXT_PACKAGE="@0@"'.format(meson.project_name()), language: 'c')

add_project_arguments(['--vapidir', vapidir], language: 'vala')
vala_flags = ['--vapidir', vapidir]

if get_option('nvidia').enabled()
vala_flags += ['--define', 'NVIDIA_SUPPORT']
endif

add_project_arguments(vala_flags, language: 'vala')

# subprojects should be skipped: https://mesonbuild.com/Release-notes-for-0-58-0.html#skip-subprojects-installation
# needs meson 0.58.0
Expand Down Expand Up @@ -48,8 +54,10 @@ app_dependencies = [
meson.get_compiler('c').find_library('pci'),
meson.get_compiler('vala').find_library('pci', dirs: vapidir),

meson.get_compiler('c').find_library('XNVCtrl'),
meson.get_compiler('vala').find_library('libxnvctrl', dirs: vapidir),
# Allow building without nvidia libraries because they're not packaged or does not run
# on some distros due to incompatibility with muslc. Also they're not needed on ARM architecture
meson.get_compiler('c').find_library('XNVCtrl', required: get_option('nvidia').enabled()),
meson.get_compiler('vala').find_library('libxnvctrl', dirs: vapidir, required: get_option('nvidia').enabled()),
]

config_data = configuration_data()
Expand Down
3 changes: 2 additions & 1 deletion meson_options.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
option('indicator-wingpanel', type : 'feature', value : 'disabled', description : 'Enables the Indicator for Wingpanel.')
option('indicator-wingpanel', type : 'feature', value : 'disabled', description : 'Enables the Indicator for Wingpanel.')
option('nvidia', type : 'feature', value : 'enabled', description : 'Build with NVIDIA support.')
2 changes: 2 additions & 0 deletions src/Resources/GPU/GPUNvidia.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ public class Monitor.GPUNvidia : IGPU, Object {
}

private void update_nv_resources () {
#if NVIDIA_SUPPORT
nvidia_resources_temperature = NVCtrl.XNVCTRLQueryAttribute (
nvidia_display,
0,
Expand Down Expand Up @@ -119,6 +120,7 @@ public class Monitor.GPUNvidia : IGPU, Object {
nvidia_fb_percentage = int.parse (((string) nvidia_used).split_set ("=,")[3]);
debug ("USED_GRAPHICS: %d%\n", nvidia_percentage);
debug ("USED_FB_MEMORY: %d%\n", nvidia_fb_percentage);
#endif

if (!nvidia_resources_used) {
warning ("Could not query NV_CTRL_STRING_GPU_UTILIZATION attribute!\n");
Expand Down