Conversation
…dering if integer values do not change on the view
danirabbit
reviewed
Mar 5, 2026
danirabbit
reviewed
Mar 5, 2026
danirabbit
reviewed
Mar 5, 2026
| public class Monitor.ProcessTreeView : Granite.Bin { | ||
| private Gtk.ColumnView list; | ||
|
|
||
| public ProcessTreeView (TreeViewModel model) { |
Member
There was a problem hiding this comment.
Can we do this gobject style?
Member
Author
There was a problem hiding this comment.
But is it necessary in this case? Model is used only in this constructor.
danirabbit
reviewed
Mar 5, 2026
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Made a few comments about code style etc
Co-authored-by: Danielle Foré <danielle@elementary.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intend is to future proof the process list and lay some ground for a tree view reintroduction.