Use Hdy.Carousel#232
Merged
danirabbit merged 5 commits intoelementary:masterfrom Sep 22, 2020
fs3o5:libhandy
Merged
Conversation
Member
|
Don't forget to update CI :) You'll need to add the libhandy package to the build step |
danirabbit
requested changes
Sep 22, 2020
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Thank you for working on this! I know this code is kind of a mess. But it looks like your branch is working very smoothly!
I've left a few inline comments about code style, but as far as I can tell this works as expected. Great job!
danirabbit
approved these changes
Sep 22, 2020
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Great job! This works super smoothly
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds #210