Conversation
because we are going to use the same thing for "tasks" as well.
Basically made sure we do everything already for events, for tasks as well.
|
@danrabbit fixed the display issues. Can you please re-review? |
|
@danrabbit any chance we can get this merged before release, or is the window already closed? |
|
Tbh I haven't had a chance to test this at all! I'm sorry. But I think we could prioritize it for shortly after release as an update :) I'll add it to the post-release project board so we don't forget |
|
@marbetschar apologies for taking so long to follow up on this! can you resolve conflicts here? |
|
@danrabbit nevermind! I resolved the conflicts. However, there now seems to be an issue with timezones (the displayed time for the task is off on my end). Do you also see any such thing on your end? I'm not entirely sure where to tackle this - maybe its even issue with how Tasks stores the time initially. @mcclurgm any chance you got some time to have a look what's off with TImeZone calculations here? |
|
I'll see if I can spare some time this evening. I've been wondering about Tasks timezones in general, I feel like it might be useful to store them as floating times. That's an issue for design though, I'll plan to open an issue to discuss. |
|
I think the issue here is that we're not converting the time zone in the Tasks code. I have a task that shows up as 13:05 in Tasks, but 6:05 in wingpanel. I checked in Evolution, and the task is actually at 13:05 UTC, which is 6:05 local. So the issue is the way we're handling timezones in Tasks code, Wingpanel is doing things properly. To check with any of your tasks, if you have Evolution you can open the problematic task and see what its time and timezone are. If I'm right, it'll show the time that's displayed in Tasks, but in the UTC timezone instead of your local timezone. |
|
@danrabbit since you added this to the release draft: Does elementary/tasks#312 prevent us from releasing this? |
danirabbit
left a comment
There was a problem hiding this comment.
Let's get this in and we can test further in early access :)

This PR fixes #211.