Skip to content

Display tasks in Wingpanel#252

Merged
danirabbit merged 24 commits intomasterfrom
tasks
Dec 2, 2021
Merged

Display tasks in Wingpanel#252
danirabbit merged 24 commits intomasterfrom
tasks

Conversation

@marbetschar
Copy link
Member

This PR fixes #211.

Screenshot from 2021-03-01 18-57-16

because we are going to use the same thing for "tasks" as well.
Basically made sure we do everything already for events, for tasks as well.
@marbetschar marbetschar requested a review from a team March 1, 2021 18:03
@cassidyjames cassidyjames requested a review from a team April 12, 2021 23:11
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like there's a lot of good cleanup with naming things more accurately etc, but I can't verify that it actually shows due tasks:

Screenshot from 2021-06-15 11 25 36

It looks like there is a dot in the calendar view with the correct color, but no row for the task

@marbetschar
Copy link
Member Author

@danrabbit fixed the display issues. Can you please re-review?

@marbetschar marbetschar requested a review from danirabbit July 29, 2021 12:20
@marbetschar
Copy link
Member Author

@danrabbit any chance we can get this merged before release, or is the window already closed?

@danirabbit
Copy link
Member

Tbh I haven't had a chance to test this at all! I'm sorry. But I think we could prioritize it for shortly after release as an update :) I'll add it to the post-release project board so we don't forget

@danirabbit
Copy link
Member

@marbetschar apologies for taking so long to follow up on this! can you resolve conflicts here?

@marbetschar
Copy link
Member Author

marbetschar commented Nov 7, 2021

@danrabbit nevermind! I resolved the conflicts. However, there now seems to be an issue with timezones (the displayed time for the task is off on my end). Do you also see any such thing on your end?

I'm not entirely sure where to tackle this - maybe its even issue with how Tasks stores the time initially. @mcclurgm any chance you got some time to have a look what's off with TImeZone calculations here?

@mcclurgm
Copy link

I'll see if I can spare some time this evening.

I've been wondering about Tasks timezones in general, I feel like it might be useful to store them as floating times. That's an issue for design though, I'll plan to open an issue to discuss.

@mcclurgm
Copy link

mcclurgm commented Nov 11, 2021

I think the issue here is that we're not converting the time zone in the Tasks code. I have a task that shows up as 13:05 in Tasks, but 6:05 in wingpanel. I checked in Evolution, and the task is actually at 13:05 UTC, which is 6:05 local. So the issue is the way we're handling timezones in Tasks code, Wingpanel is doing things properly.

To check with any of your tasks, if you have Evolution you can open the problematic task and see what its time and timezone are. If I'm right, it'll show the time that's displayed in Tasks, but in the UTC timezone instead of your local timezone.

@danirabbit danirabbit mentioned this pull request Nov 19, 2021
3 tasks
@marbetschar
Copy link
Member Author

@danrabbit since you added this to the release draft: Does elementary/tasks#312 prevent us from releasing this?

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in and we can test further in early access :)

@danirabbit danirabbit merged commit e53b46e into master Dec 2, 2021
@danirabbit danirabbit deleted the tasks branch December 2, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for tasks

4 participants