Skip to content

Indicator: open Calendar on middle-click#294

Merged
danirabbit merged 4 commits intomasterfrom
middle-click-calendar
Dec 8, 2021
Merged

Indicator: open Calendar on middle-click#294
danirabbit merged 4 commits intomasterfrom
middle-click-calendar

Conversation

@danirabbit
Copy link
Member

Fixes #286

@danirabbit danirabbit requested a review from jeremypw December 3, 2021 18:45
@danirabbit danirabbit mentioned this pull request Dec 3, 2021
3 tasks
@marbetschar
Copy link
Member

Not tested yet, but I think the tooltip is missing which is displayed on other elements in Wingpanel for the middle click, such as:

Screenshot from 2021-12-04 11-08-01@2x

@marbetschar
Copy link
Member

marbetschar commented Dec 4, 2021

Possible text for the tooltip (depending on state):

1 event and 3 tasks planned for today
Middle-click to open Calendar

Other states:

  • If there are events but no tasks:
    • 2 events planned for today
  • if there are tasks but no events:
    • 1 task planned for today
  • if there are no events and no tasks:
    • Nothing planned for today

@danirabbit
Copy link
Member Author

@marbetschar I added a tooltip for the middle click action, but I think adding a summary is a bit outside the scope of this branch

@marbetschar
Copy link
Member

marbetschar commented Dec 8, 2021

LGTM - feel free to merge, because I lost the ability to merge because I merged from master ... again :)

UPDATE: Added #295 as idea, so we can work on this separately.

@tintou tintou enabled auto-merge (squash) December 8, 2021 10:34
@danirabbit danirabbit disabled auto-merge December 8, 2021 20:34
@danirabbit danirabbit merged commit 1b8fa36 into master Dec 8, 2021
@danirabbit danirabbit deleted the middle-click-calendar branch December 8, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide middle-click action to open current day in calendar

2 participants