Fix installing check-for-firmware-updates files in NixOS#74
Merged
Conversation
lenemter
requested changes
Jul 25, 2023
Member
lenemter
left a comment
lenemter
left a comment
There was a problem hiding this comment.
get_pkgconfig_variable is deprecated, we should use get_variable now.
Merged
As a weird distro, we install packages in their own separate prefixes, which means we don't have /usr/bin/busctl, and we cannot install files to systemd's prefix.
bobby285271
force-pushed
the
bobby285271/fix-nixos
branch
from
c52f57e to
d4e65a6
Compare
lenemter
approved these changes
Jul 25, 2023
Member
lenemter
left a comment
lenemter
left a comment
There was a problem hiding this comment.
Looks good and works same as master in elementary OS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(review with hide whitespace)
As a weird distro, we install packages in their own separate prefixes, which means we don't have
/usr/bin/busctl, and we cannot install files to systemd's prefix.(I can kill the
busctlpathmeson options if preferred, since we are not usingfind_programI assume cross compilation should be fine here?)