dynamic growth of handle dsyms and lsyms, capstone rename#6
Open
Silur wants to merge 2 commits intoelfmaster:masterfrom
Open
dynamic growth of handle dsyms and lsyms, capstone rename#6Silur wants to merge 2 commits intoelfmaster:masterfrom
Silur wants to merge 2 commits intoelfmaster:masterfrom
Conversation
elfmaster
reviewed
Mar 26, 2018
Owner
elfmaster
left a comment
There was a problem hiding this comment.
Let me take a closer look at this. I abandoned this project long ago because I wrote the code when I had no time to write it, in a very short period of time, and I am working on a version that does not require ptrace in the very near future. However let me take a peek at your code and we can merge it in if you like, give me a few days.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Loading large executables produces a segfault because of the default 8192*2 max symbol limit that is also not checked for overflows.
Solution
handle structs dsym and lsym became a pointer and automatically grows on heap when needed.
Problem
building failed because
Makefilesearched forcapstonefolder, while git hascapstone-2.1.2Solution
Renaming folder to
capstone, don't know whether this is more straight-forward than editing the makefile though.