Allow iterator to return ELF_ITER_NOTFOUND when not found.#14
Merged
elfmaster merged 1 commit intoelfmaster:masterfrom Feb 7, 2020
Merged
Allow iterator to return ELF_ITER_NOTFOUND when not found.#14elfmaster merged 1 commit intoelfmaster:masterfrom
ELF_ITER_NOTFOUND when not found.#14elfmaster merged 1 commit intoelfmaster:masterfrom
Conversation
Previously, when using `elf_shared_object_iterator_next`, if `ldso_cache_bsearch` fails to find a file, it would return an error, causing the iterator to become useless and no longer iterate. This will allow the caller to consume an `ELF_ITER_NOTFOUND` event and continue processing dependancies.
Owner
|
Nice work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when using
elf_shared_object_iterator_next, ifldso_cache_bsearchfails to find a file, it would return an error, causing the iterator to become useless
and no longer iterate. This will allow the caller to consume an
ELF_ITER_NOTFOUNDevent and continue processing dependancies.