60secondsassassin patch 1#1183
Open
60secondsassassin wants to merge 4 commits into
Open
Conversation
fix: timing issue for SetViewMode
Add a comment to clarify the purpose of setting the ViewMode.
Implement robust path translation for icons and thumbnails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Inconsistent ViewMode application + local icons when in remote server mode
Description
This PR fixes the issue where Elementum fails to apply the configured View ID (Posters, List, etc.) when navigating through directories.
The fix involves:
xbmcplugin.endOfDirectoryis called before attempting to set the view.SetViewModecommand is sent.Related Issue
Fixes inconsistent UI behavior on Kodi 20/21, especially on low-end hardware where the UI thread is slower than the Python execution.
Motivation and Context
Currently, the
Container.SetViewModecommand often fires while the directory is still "loading," causing Kodi to ignore it and fall back to the skin's default view. By finalizing the directory first and adding a slight delay, we ensure the command is received when the UI is ready to process it.How Has This Been Tested?
Screenshots (if appropriate):
(Optionnel : tu peux ajouter ici une capture d'écran de l'affichage correct des Posters)
Types of changes
Checklist: