Conversation
Updated the readme with an example of turning a list of maps into a dataframe.
billylanchantin
requested changes
Aug 15, 2025
Member
billylanchantin
left a comment
There was a problem hiding this comment.
Thanks, @Zesky665! I agree this explanation could be improved.
Actually, can I ask that we expand the scope of your changes a bit? Something like this:
You can pass the data in column-wise as a map (or keyword) of series:
```elixir
name = Explorer.Series.from_list(["Everest", "K2", "Aconcagua"])
elevation = Explorer.Series.from_list([8848, 8611, 6962])
mountains = Explorer.DataFrame.new(name: name, elevation: elevation)
```
Or you can pass the data in column-wise as a map (or keyword) of lists:
```elixir
mountains = Explorer.DataFrame.new(
name: ["Everest", "K2", "Aconcagua"],
elevation: [8848, 8611, 6962]
)
```
Or you can pass it in row-wise as a list of maps (or keywords):
```elixir
mountains = Explorer.DataFrame.new([
[name: "Everest", elevation: 8848],
[name: "K2", elevation: 8611],
[name: "Aconcagua", elevation: 6962]
])
```
All are equivalent, and your dataframe will look like this:
This way, your change and the clause that precedes will feel cohesive IMO. I leave the exact wording up to you, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the readme with an example of turning a list of maps into a dataframe.