Fix automatic legacy_cpu detection for polars rustler#1131
Open
nabijaczleweli wants to merge 1 commit intoelixir-explorer:mainfrom
Open
Fix automatic legacy_cpu detection for polars rustler#1131nabijaczleweli wants to merge 1 commit intoelixir-explorer:mainfrom
nabijaczleweli wants to merge 1 commit intoelixir-explorer:mainfrom
Conversation
Before: $ mix ecto.setup ==> explorer Compiling 29 files (.ex) 20:07:38.808 [debug] Copying NIF from cache and extracting to /home/nabijaczleweli/work/beambox-logbook/_build/dev/lib/explorer/priv/native/libexplorer-v0.10.1-nif-2.15-x86_64-unknown-linux-gnu.so.tar.gz Illegal instruction $ for f in fxsr sse sse2 ssse3 sse4_1 sse4_2 popcnt avx fma; do grep -m1 flags /proc/cpuinfo | grep -wq $f || echo no $f; done no avx no fma $ mix deps.get use_legacy: false is_nil(use_legacy): false needed_caps: ["fxsr", "sse", "sse2", "ssse3", "sse4_1", "sse4_2", "popcnt", "avx", "fma"] Explorer.ComptimeUtils.cpu_with_all_caps?(needed_caps): false use_legacy or (is_nil(use_legacy) and not Explorer.ComptimeUtils.cpu_with_all_caps?(needed_caps)): false After: $ mix ecto.setup ==> explorer Compiling 29 files (.ex) use_legacy: nil is_nil(use_legacy): true needed_caps: ["fxsr", "sse", "sse2", "ssse3", "sse4_1", "sse4_2", "popcnt", "avx", "fma"] Explorer.ComptimeUtils.cpu_with_all_caps?(needed_caps): false if is_nil(use_legacy), do: not Explorer.ComptimeUtils.cpu_with_all_caps?(needed_caps), else: use_legacy: true 20:32:03.923 [debug] Copying NIF from cache and extracting to /home/nabijaczleweli/work/beambox-logbook/_build/dev/lib/explorer/priv/native/libexplorer-v0.10.1-nif-2.15-x86_64-unknown-linux-gnu--legacy_cpu.so.tar.gz Sponsored-by: https://beaverlabs.net
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
and indeed I'm missing some features:
Some
IO.inspects revealuse_legacyis always a bool, sinceApplication.compile_env/3's default argument ofSystem.get_env("EXPLORER_USE_LEGACY_ARTIFACTS") in ["true", "1"]is always a bool:After: