Fix binary uuid casting#121
Merged
warmwaffles merged 3 commits intoAug 29, 2023
Merged
Conversation
added 3 commits
August 29, 2023 04:12
warmwaffles
approved these changes
Aug 29, 2023
Member
warmwaffles
left a comment
warmwaffles
left a comment
There was a problem hiding this comment.
Thank you for doing this. I'll need to chuck a test or two into the ecto/adapters/sqlite3/connection directory that check the select statements but this solves the immediate problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this solves your issue here: #119
I'm not too familiar with SQLite but from what I can tell from the tests it doesn't like it when
cast(_ as blob)is used. It seems to work when the casting is removed.