Skip to content

Add support for nil value in datetime column#136

Merged
warmwaffles merged 3 commits into
elixir-sqlite:mainfrom
gshaw:main
Dec 14, 2023
Merged

Add support for nil value in datetime column#136
warmwaffles merged 3 commits into
elixir-sqlite:mainfrom
gshaw:main

Conversation

@gshaw
Copy link
Copy Markdown
Contributor

@gshaw gshaw commented Dec 9, 2023

Currently you can read nil values but you can't write nil values to a datetime column. This PR fixes this.

@gshaw gshaw changed the title Add support for nil datetime types Add support for nil values in datetime columns Dec 9, 2023
@gshaw gshaw changed the title Add support for nil values in datetime columns Add support for nil value in datetime column Dec 9, 2023
@warmwaffles
Copy link
Copy Markdown
Member

Oh this is silly and should have been caught. Can you add a test in Ecto.Integration.TimestampsTest? Feel free to add a column or table to EctoSQLite3.Integration.Migration.

@warmwaffles warmwaffles merged commit fdb5f41 into elixir-sqlite:main Dec 14, 2023
@warmwaffles
Copy link
Copy Markdown
Member

Awesome! I'll get this cut asap.

@gshaw
Copy link
Copy Markdown
Contributor Author

gshaw commented Dec 14, 2023

Appreciate it getting merged. Happy to contribute in a small way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants