Encodes nil blobs for updates#140
Merged
Merged
Conversation
warmwaffles
approved these changes
Feb 3, 2024
Member
|
Just need to get the linting issue sorted and I'll merge it in. Thank you for fixing this! |
Contributor
Author
|
Thanks @warmwaffles |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently upgraded some dependencies and found what appears to be a regression in
ecto_sqlite3's ability to update blob/binary fields into NULL (nil).This PR contains a new test case for this purpose. Excerpt:
On the latest main, the following error is generated:
Including my small change to
blob_encode/1allows all tests to pass:Please let me know what you think!
-Jesse