fix: skip Privy error screen when Steward auth is enabled#447
Conversation
When NEXT_PUBLIC_STEWARD_AUTH_ENABLED=true and Privy isn't configured, PrivyProvider passes children through instead of blocking with error. Also fix StewardProvider props in login page. Co-authored-by: wakesync <shadow@shad0w.xyz>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code ReviewOverall this is a reasonable fix for unblocking Steward-only deployments, but there are a few issues worth addressing before merge. Bug:
|
| Severity | Issue |
|---|---|
| Bug | agentId="" — should be "eliza-cloud" to match existing provider |
| Bug | Missing AuthTokenSync — Steward JWT won't propagate to global API client after login |
| Performance | new StewardClient(...) inside JSX — recreated on every render |
| Code quality | as any cast hides a real type mismatch |
| Nit | Double || undefined coercion |
The cleanest resolution for most of these is to reuse the existing StewardAuthProvider instead of re-implementing StewardProvider inline — it already handles the client memoization, config validation, and JWT sync correctly.
|
test |
When
NEXT_PUBLIC_STEWARD_AUTH_ENABLED=trueand Privy isn't configured, the PrivyProvider now passes children through instead of showing the 'Configuration Error' screen. This lets Steward handle auth without requiring Privy credentials.Also fixes StewardProvider props in login page (needs
client+agentId).Follows from #446.
Co-authored-by: wakesync shadow@shad0w.xyz