Refactor: Introduce useActionHandler pattern and standardize logging#14
Open
plvo wants to merge 1 commit intoelizaos-plugins:1.xfrom
Open
Refactor: Introduce useActionHandler pattern and standardize logging#14plvo wants to merge 1 commit intoelizaos-plugins:1.xfrom
useActionHandler pattern and standardize logging#14plvo wants to merge 1 commit intoelizaos-plugins:1.xfrom
Conversation
- Updated `tsconfig.json` to include path mappings for easier imports. - Replaced `logger` with `mcpLogger` in various files to standardize logging for MCP-related actions. - Refactored action handlers (`callToolAction`, `readResourceAction`) to utilize the new logging mechanism and improve error handling. - Removed deprecated resource selection schemas from `types.ts`. - Improved validation and selection processes for tools and resources, ensuring better error reporting and handling. - Cleaned up unused imports and optimized code structure for clarity and maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the MCP plugin actions to use a centralized context pattern and improves logging consistency across the codebase.
Key Changes
Context-based Action Handler Pattern
useActionHandlerutility that returns a completeActionHandlerContextcallToolAction.tsandreadResourceAction.tsBefore:
After:
Standardized Logging with
mcpLoggerloggerusage with centralizedmcpLogger[MCP]prefixes and contextual tags ([CALLING],[SELECTED],[HANDLE])Code Organization
typeimportsImproved Error Handling
Impact