Improve performance of List.append#1026
Improve performance of List.append#1026jhrcek wants to merge 1 commit intoelm:masterfrom jhrcek:fasterListConcat
Conversation
|
So In theory, this should mean that This PR proposes to increase performance of There are several different ways to solve this, all of which requires careful benchmarking and perhaps some design discussion with Evan to make sure the actual fix has long life (it would be bad to implement a fix which is negated by future code generation or language changes). I'm planning on taking a closer look at the implementation of List functions during the next week or two, and I'll be sure to figure out the best way to improve the performance of If I reach the conclusion that this PR is as good a fix as any other, I'll be sure to say so and recommend the merging of this PR (credit were credit is due). I do, however, believe there is a better fix to this and I'm planning on writing that up soon. |
|
Fixed in #1027 |
I did some benchmarks and it turns out that thanks to this improvement the implementation of
List.concatabout 2x (in Google Chrome) to 3x (in Firefox) faster than the current implementation.