Open
Conversation
jerith666
force-pushed
the
fix-list-equality-combined
branch
from
bbf8d34 to
570734f
Compare
…st-equality-combined
Conflicts:
src/Elm/Kernel/Utils.js
-- keep comment from HEAD^1
tests/tests/Test/Equality.elm
-- keep additional tests from HEAD^1
Contributor
Author
|
Now that #1031 has been merged, all that's left here are the additional tests. I've resolved the conflict in case you want to include them. |
evancz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do non-recursive tests before the depth check. this ensures that the
'for(key in x)' loop properly short-circuits, and avoids putting
Tuple2s containing 'undefined' on the stack.
fixes #1011; see that issue and #1031 for further discussion
listTests by @Skinney