Conversation
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
|
This is a good patch and fixes a subtle bug that people could spend hours figuring out. This patch is old enough that in the mean time JSON stuff got moved to a separate package from core. Would you be able to open a new PR against |
|
Hi, thanks for looking into this old PR! I'm on vacation right now and also have been out of touch with Elm for a while. If you need this fix soon, please feel free to create a PR to the elm/json repo. |
|
If you are out of touch with Elm, then I will create the PR in elm/json - your fix applies just the same in the new package. |
Fixes #904
_Json_listEqualityas_Json_arrayEqualitybecause it actually works on JavaScript arrays instead ofLists_Json_listEqualityfunction that works on ElmLists