You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If the user doesn't set the search engine and their request fails, I set the search engine to be "google" and recall the "getLyrics" method and store the output in a local variable. After that method runs, the search engine is set back to default and the output from that method that was stored in the local variable is return to the original caller.
This is an update from the previous commit from my "retries" branch that resolves some conflicts with original PR.
I had to delete your manual "404" return. To recap my changes, whenever the "getLyrics" or "getSongs" is called and the status code is not "200", then my code looks to see if the user specified a search engine.
-> If they did not, then it sets the search engine to Google and recurses, and resets itself back to self.search_engine='' after it returns. If
-> If the user DID specific a search engine (which also covers the case above where the function automatically recurses), then it returns the ACTUAL status code of the request instead of the hard-coded 404 error. This gives more accurate information for the cause of the issue whenever a look up fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user doesn't set the search engine and their request fails, I set the search engine to be "google" and recall the "getLyrics" method and store the output in a local variable. After that method runs, the search engine is set back to default and the output from that method that was stored in the local variable is return to the original caller.
This is an update from the previous commit from my "retries" branch that resolves some conflicts with original PR.