Conversation
This PR adapts the code to the new format suggested in ember-cli/ember-rfc176-data#37.
Serabe
force-pushed
the
feature/new-format
branch
from
57702b1 to
95b2415
Compare
|
This looks good to me. We need to decide what to do about those deprecated modules now. The reason I bring this up is that with this change this babel plugin will support the old shims (which it hasn't done to date). I think, generally speaking, we should emit deprecation noticies to the console, but since we don't have a good build runtime deprecation solution yet in ember-cli I'm slightly hesitant to suggest each of these emit a console message... |
|
We should add |
|
Added notifier as parameter. Not sure if it is the way you were thinking of, though. |
|
Fixed a problem in Node 4 |
src/index.js
Outdated
| if (mapping) { | ||
|
|
||
| if (mapping.deprecated) { | ||
| notifyDeprecation(`Module ${importPath} is deprecated.`, notifier); |
There was a problem hiding this comment.
We should flesh this out a bit more to include what file was being transpiled and what the replacement is (if any). Otherwise this isn't very actionable.
@Serabe - I'm going to disable the deprecation system for now, so that we can release (and keep parity). Can you work on this in a follow up PR?
We definitely should bring this back, but for now we should disable until we can make the deprecations more actionable.
|
Updated for release version of ember-rfc176-data (and to kick off another CI run). Once green, this should be good to go... |
2 participants
This PR adapts the code to the new format suggested in
ember-cli/ember-rfc176-data#37.