Skip to content
This repository was archived by the owner on Dec 8, 2024. It is now read-only.

Pass through filename as modulename to precompile#475

Open
chiragpat wants to merge 1 commit intoember-cli:masterfrom
chiragpat:meta-module-name
Open

Pass through filename as modulename to precompile#475
chiragpat wants to merge 1 commit intoember-cli:masterfrom
chiragpat:meta-module-name

Conversation

@chiragpat
Copy link

Why

Passing in moduleName will allow astPlugins to have access to the name of the current file they are processing. This will enable them to provide friendly error messages.

How

  • Pass through state.file.opts.fileName to calls to the precompile function

@chiragpat chiragpat changed the title Pass through correct filename as modulename to precompile Pass through filename as modulename to precompile Sep 15, 2021
@rwjblue
Copy link
Member

rwjblue commented Oct 6, 2021

Hmph. I thought this was already available? 🤔

@chiragpat
Copy link
Author

Nope it got removed, not sure exactly when it happened.

@rwjblue
Copy link
Member

rwjblue commented Oct 7, 2021

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants