This repository was archived by the owner on Jan 30, 2023. It is now read-only.
Clone options object before modifying it #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `options` object could be frozen and therefore not modifiable. It is safer to work with a clone of it.
Collaborator
|
Great points, thanks @gnapse! |
Collaborator
|
Hmm, I know I already merged it but would you mind adding a test case for this in a separate PR @gnapse? |
Contributor
Author
|
Sure @alexlafroscia, I just did. Check out #227. |
alexlafroscia
pushed a commit
that referenced
this pull request
Jan 17, 2017
alexlafroscia
pushed a commit
that referenced
this pull request
Feb 15, 2017
* Clone options object before modifying it The `options` object could be frozen and therefore not modifiable. It is safer to work with a clone of it. * Avoid accessing Ember.merge directly
alexlafroscia
pushed a commit
that referenced
this pull request
Feb 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
optionsobject could be frozen and therefore not modifiable. It is safer to work with a clone of it. This PR does just that.If for some reason it is not acceptable to assign to the
optionsargument, let me know and I can modify this accordingly.