Skip to content
This repository was archived by the owner on Feb 6, 2021. It is now read-only.
This repository was archived by the owner on Feb 6, 2021. It is now read-only.

Does not respect ember-cli-htmlbars' wrapper.cacheKey() #109

@amiller-gh

Description

@amiller-gh

Expected Behavior:

Both ember-cli-htmlbars and ember-cli-htmlbars-inline-precompile should allow plugins to provide the same caching scheme.

Observed Behavior:

ember-cli-htmlbars allows plugins to provide a custom cache key if the addon's baseDir() is not sufficient: https://github.com/ember-cli/ember-cli-htmlbars/blob/master/ember-addon-main.js#L121

ember-cli-htmlbars-inline-precompile does not allow for this: https://github.com/ember-cli/ember-cli-htmlbars-inline-precompile/blob/master/index.js#L117

Proposed Fix:

Port ember-cli-htmlbars' plugin cacheKey() method to ember-cli-htmlbars-inline-precompile.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions