Introduces ability to extract pragma tag from the template#114
Closed
twokul wants to merge 1 commit intoember-cli:masterfrom
twokul:pragma-tag-extraction
Closed
Introduces ability to extract pragma tag from the template#114twokul wants to merge 1 commit intoember-cli:masterfrom twokul:pragma-tag-extraction
twokul wants to merge 1 commit intoember-cli:masterfrom
twokul:pragma-tag-extraction
Conversation
rwjblue
reviewed
May 18, 2017
index.js
Outdated
| } | ||
|
|
||
| precompile(content, options) { | ||
| return this.options.templateCompiler.precompile(content, options); |
Member
There was a problem hiding this comment.
We need to funnel this through utils.template still
index.js
Outdated
| contents: string, | ||
| moduleName: relativePath | ||
| }) + ';'; | ||
| return 'export default Ember.HTMLBars.template(' + this.precompile(stripBom(string), { |
Member
There was a problem hiding this comment.
Can you break this up a bit so that we don't have so many invocations? Just thinking that we could make a few variables, and then use simple template string to concat...
(I know this isn't a new problem with this PR though...)
Current pragma tag proposal is {{use-component-manager ""}}.
Before compiling the template "" part would be extracted and
set on template's metadata.
Author
|
I think this can be safely closed as this change is going to be landed upstream, see emberjs/ember.js#15254 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current pragma tag proposal is {{use-component-manager "manager-id"}}.
Before compiling the template "manager-id" part would be extracted and
set on template's metadata.