Skip to content
This repository was archived by the owner on Dec 8, 2024. It is now read-only.

Added isHTMLSafe to the ember-string shims.#93

Closed
workmanw wants to merge 1 commit intoember-cli:masterfrom
workmanw:add-ishtmlsafe-polyfill
Closed

Added isHTMLSafe to the ember-string shims.#93
workmanw wants to merge 1 commit intoember-cli:masterfrom
workmanw:add-ishtmlsafe-polyfill

Conversation

@workmanw
Copy link

@workmanw workmanw commented Mar 5, 2017

So Ember.String.isHTMLSafe was added in Ember 2.8. I was tempted to include the ember-string-ishtmlsafe-polyfill as a dependency, however we've been following the pattern of ember-assign-polyfill and ember-getowner-polyfill and neither of them are deps here.

I think it's logical to say that a consumer of ember-cli-shims using < Ember-2.8 has to also include the ember-string-ishtmlsafe-polyfill for themselves.

@locks
Copy link
Contributor

locks commented Apr 22, 2017

Hey @workmanw, it is my understanding that the old shims are frozen and we intend to deprecate them as you can see in #92. I am closing this due to the previous reasoning.
From your description it sounds like you have a path forward? Ping on Slack if otherwise, I volunteer rwj ;)

@locks locks closed this Apr 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants