Merged
Conversation
Member
|
Seems good to me. Doing this on master would mean we drop Node 7 support in 2.18, which seems fine to me... |
rwjblue
approved these changes
Oct 13, 2017
rwjblue
requested review from
Turbo87,
hjdivad,
kategengler,
kratiahuja and
stefanpenner
Member
|
Is there a Node 9 already that we could replace it with? |
Member
|
Not yet, but based on the schedule here there should be a Node 9 out sometime this month (essentially when Node 8 becomes LTS, Node 9 should be released). |
Turbo87
approved these changes
Oct 13, 2017
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do y'all feel like it's time?