Merged
Conversation
Contributor
Author
Member
|
Restarted that CI job |
This was referenced Apr 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #7726
In my attempt to simplify a quite complex piece of code while adding an additional condition, I inadvertently modified the logic such that
mainBlueprint.supportsAddon()was called in more cases that before my change. It seems that callingblueprint.supportsAddon()has some side-effects (as it callsblueprint.files()) which resulted in some blueprint code executing without having a reference tothis.project: #7726Here is the original logic:
This is all quite brittle, but as this code will be removed once MU takes over the world, I think it's ok to leave as is.