Deprecation in ember-cli 2.18?

[ScottLNorvell]

Hi, getting the following Deprecation warning while running ember server on ember-cli 2.18

DEPRECATION: An addon is trying to access project.nodeModulesPath. This is not a reliable way to discover npm modules. Instead, consider doing: require("resolve").sync(something, { basedir: project.root }). Accessed from: DependencyVersionChecker.NPMDependencyVersionChecker (/Users/snorvell/code/cne/alt-versions/player-frontend-ALT/node_modules/ember-export-application-global/node_modules/ember-cli-version-checker/index.js:137:32)

Thanks!

[rwjblue]

Hmm, I don't believe the current version has this issue. What does npm ls ember-export-application-global report?

[ScottLNorvell]

thanks for the quick reply! Is this what you're looking for?

> yarn list --pattern ember-export-application-global
yarn list v1.3.2
└─ ember-export-application-global@2.0.0
✨  Done in 1.28s.

(our shop uses yarn, but looks like it does the same thing)

[rwjblue]

Ya, thank you!

My best guess is that you have an older/locked version of ember-cli-version-checker pinned under ember-cli-babel (since this library only has ember-cli-babel as a dependency) and haven't done a yarn upgrade-interactive / yarn upgrade to get the newer ember-cli-babel version.

Can you double check that via yarn list ember-cli-babel and yarn list ember-cli-version-checker?

[ScottLNorvell]

Here you go!

> yarn list --pattern ember-cli-babel
yarn list v1.3.2
├─ ember-cli-babel@6.11.0
├─ ember-cli-bourbon@1.2.2
│  └─ ember-cli-babel@5.1.10
├─ ember-export-application-global@2.0.0
│  └─ ember-cli-babel@6.0.0-beta.9
└─ ember-load-initializers@1.0.0
   └─ ember-cli-babel@6.0.0-beta.9
✨  Done in 1.30s.
> yarn list --pattern ember-cli-version-checker
yarn list v1.3.2
├─ ember-cli-bourbon@1.2.2
│  └─ ember-cli-version-checker@1.2.0
├─ ember-cli-version-checker@2.1.0
├─ ember-export-application-global@2.0.0
│  └─ ember-cli-version-checker@1.2.0
└─ ember-load-initializers@1.0.0
   └─ ember-cli-version-checker@1.2.0
✨  Done in 1.48s.

It looks like ember-export-application-global points to a beta version of ember-cli-babel (as does ember-load-initializers). I'm not sure why it's loading that version given the ^. A brand new ember app with yarn loads the "correct" version of ember-cli-babel I tried yarn linking ember-export-application-global locally and bumped it's version of ember-cli-babel to the current and it cleared the deprecation warning for ember-export-application-global. (however then there was one for ember-load-initializers...) I assume bumping the ember-cli-babel version there would fix as well.

For a little bit of context, I just did a huge jump in an existing application from ember/ember-cli 2.11 all the way up to 2.18. I may or may not have done everything "by the book", but I do have a working application now! I just thought I'd investigate the deprecation warnings. Thanks so much for your help on this!

[rwjblue]

It looks like ember-export-application-global points to a beta version of ember-cli-babel (as does ember-load-initializers). I'm not sure why it's loading that version given the ^. A brand new ember app with yarn loads the "correct" version of ember-cli-babel

By default the deps are locked down in your yarn.lock, and without a yarn upgrade you will not get these transient deps to update to newer allowed versions.

I assume bumping the ember-cli-babel version there would fix as well

Ya, and FWIW, I'm happy to land a PR that updates to latest ember-cli-babel@6 version and release just to ease the burden for others struggling with the same issue...

[ScottLNorvell]

Ok, PR submitted! Thanks again for your help.