Deprecate Logger and merge #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
where does it say that? |
Member
Author
|
@nlfurniss Sorry, I meant |
Collaborator
|
Why do we want to cover back to 2.3? |
Member
Author
|
The compatible versions were not specified explicitly. But I think it would be nice to have for user to know about and mention what are the versions we drop support in next release. It was when removing I wanted to verify the oldest ember version we are actually supporting. |
Member
|
ember-assign-polyfill specifically exists for this reason |
Member
|
However, we should strongly consider officially dropping support for Ember < 2.16... |
xg-wang
force-pushed
the
upgrade
branch
3 times, most recently
from
ac97312 to
23e0450
Compare
- Ember.Logger(RFC297) - Ember.merge(RFC340) Drop support for ember<2.16 Use whatwg-fetch instead of forked version. Changes to match spec: - unsupported body type convert to string rather than throw exception - credentials default changed from 'omit' to 'same-origin'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecations
ember-try version compatibility now covers back to ember2.3
@rwjblue The deprecation guide says
Ember.assignis not available in Ember <= 2.4, but I found it in old release branches. Am I missing anything here?Also use whatwg-fetch instead of forked version. Breaking changes include:
credentialsdefault value tosame-originRelated PR pretenderjs/pretender#235
This can be a major bump with #130 (comment)