Skip to content

Fix whatwg-fetch 3.4 global object name change compatibility #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xg-wang merged 2 commits into from
Aug 10, 2020
Merged

Fix whatwg-fetch 3.4 global object name change compatibility #552

xg-wang merged 2 commits into from
Aug 10, 2020

Conversation

@xg-wang
Copy link
Member

@xg-wang xg-wang commented Aug 9, 2020

Fix #547

@xg-wang xg-wang added bug dependencies Pull requests that update a dependency file test labels Aug 10, 2020
@xg-wang xg-wang merged commit 4f266b6 into ember-cli:master Aug 10, 2020
@xg-wang xg-wang deleted the fix-fetch-3-4 branch August 10, 2020 00:55
@chancancode chancancode mentioned this pull request Aug 10, 2020
Closed
rwjblue
rwjblue reviewed Aug 10, 2020
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xg-wang!

@xg-wang xg-wang mentioned this pull request Aug 11, 2020
Closed
@snewcomer snewcomer mentioned this pull request Aug 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwjblue rwjblue rwjblue left review comments

Assignees

No one assigned

Labels

bug dependencies Pull requests that update a dependency file test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fetch is not defined - maybe your browser targets are not covering everything you need

2 participants

@xg-wang @rwjblue