Merged
Conversation
GavinJoyce
commented
Apr 16, 2018
| "ember-data": "^2.17.0", | ||
| "ember-disable-prototype-extensions": "^1.1.2", | ||
| "ember-export-application-global": "^2.0.0", | ||
| "ember-load-initializers": "^1.0.0", |
Contributor
Author
There was a problem hiding this comment.
removing this so that we're testing the local project, not the published package
GavinJoyce
commented
Apr 16, 2018
| instanceInitializers.push(moduleName); | ||
| if (!_endsWith(moduleName, '-test')) { | ||
| instanceInitializers.push(moduleName); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
without these changes, the app fails to boot with:
GavinJoyce
force-pushed
the
gj/allow-colocated-test-files
branch
from
2796558 to
12599b5
Compare
GavinJoyce
force-pushed
the
gj/allow-colocated-test-files
branch
from
12599b5 to
6b6e40c
Compare
Contributor
Author
|
/cc @rwjblue (perhaps you could publish too if you're 👍?) |
|
Thanks Gavin; I think this change fixes #47. |
rwjblue
approved these changes
Apr 17, 2018
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With module unification, test files can be colocated with initializers. This PR avoids registering initializers and application-initializers which end in
-test.This will unblock work on MU blueprints such as emberjs/ember.js#16489 (comment)