make page-title-setup initializer fastboot compatible#70
Merged
tim-evans merged 2 commits intoember-cli:masterfrom Jun 1, 2017
Merged
make page-title-setup initializer fastboot compatible#70tim-evans merged 2 commits intoember-cli:masterfrom
tim-evans merged 2 commits intoember-cli:masterfrom
Conversation
Contributor
|
Wooo! Thanks |
buschtoens
changed the title
Contributor
Author
|
ember-fastboot/ember-cli-head#21 (comment) Good to merge. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69
https://gist.github.com/kratiahuja/d22de0fb1660cf0ef58f07a6bcbf1a1c#addon-contains-browser-based-initializers-as-appinstance-initializersbrowserjs
Tested against ember-fastboot/ember-cli-head#21 and works. I'll keep this on WIP and upgrade the version for
ember-cli-headinpackage.jsonas soon as the linked PR is merged. Subscribed to it. 🙂