@ember/string deprecation warnings

[Windvis]

I noticed that the ember-canary scenario started showing a lot of deprecation warnings which seemed to be triggered be this addon.

DEPRECATION: Importing from `@ember/string` without having the `@ember/string` package in your project is deprecated. Please add `@ember/string` to your `package.json [deprecation id: ember-string.add-package] This will be removed in ember-source 5.0.0. See https://deprecations.emberjs.com/v4.x/#toc_ember-string-add-package for more details.

ember-resolver/addon/addon/resolvers/classic/index.js

Line 8 in 262a463

import { dasherize, classify, underscore } from '@ember/string';

[kategengler]

@Windvis Thanks for opening the issue! Handling this (and any other @ember/string deprecations in a new app) is my next step.

[kategengler]

fixed by #862 and released in v10.0.0

[pzubar]

Thanks for this fix @kategengler!
Still, I have a question regarding the case when the only package that imports from @ember/string is ember-resolver. Should I still add @ember/string to my package.json to avoid getting the warning, or there is a better solution? Thank you in advance!

[kategengler]

@pzubar @ember/string is a peerDependency, but not an optional one. ember-resolver requires @ember/string to be added to the host project to work correctly. It is a peer dependency rather than a dependency because many packages may use @ember/string but there should only be one copy of it to share the caches in @ember/string. See https://nodejs.org/es/blog/npm/peer-dependencies/ for more about peerDeps and #862 (comment) for more on why we chose a peerDep.