Conversation
README.md
Outdated
| ## Installation | ||
|
|
||
| Ember-resolver was previously a bower package, but since v1.0.1, it has become an ember-cli addon, and should be installed with `ember install`: | ||
| Ember-resolver is an ember-cli addon, and should be installed with `ember install`: |
There was a problem hiding this comment.
Nit picky, but seems odd to hyphenate and capitalize.
| flag settings change how `ember-resolver` compiles into an ember-cli's | ||
| `vendor.js`, so you should think of them as an application build-time option. | ||
|
|
||
| Feature flags are set in an application's `config/environment.js`: |
There was a problem hiding this comment.
Ideally we change this to use ember-cli-build.js instead (no need to leak these to the browser), but we should do that in a follow up I think...
README.md
Outdated
|
|
||
| module.exports = function(environment) { | ||
| var ENV = { | ||
| emberResolver: { |
There was a problem hiding this comment.
I know it is annoying, but I generally prefer to use the exact package name for the key here:
ENV = {
'ember-resolver': { }
}| /* ... */ | ||
| ``` | ||
|
|
||
| Note that you must restart your ember-cli server for changes to the `flags` to |
There was a problem hiding this comment.
When we move to ember-cli-build.js this becomes more obvious, since no changes to ember-cli-build.js are detected and updated without a restart today.
index.js
Outdated
| }, | ||
| envFlags: { | ||
| source: 'ember-resolver-env-flags', | ||
| flags: { DEBUG: options.environment !== 'production' } |
There was a problem hiding this comment.
This should be process.env.EMBER_ENV != 'production', not sure what options.environment is here?
index.js
Outdated
| plugins: [ | ||
| [require('babel-plugin-debug-macros').default, { | ||
| debugTools: { | ||
| source: 'ember-debug' |
There was a problem hiding this comment.
We should use the JS module unification module here I think, which would be @ember/debug.
mixonic
force-pushed
the
feature-flags
branch
2 times, most recently
from
0fb0cb2 to
63a025f
Compare
|
@rwjblue I've clean up a few things per your notes |
|
Travis is failing for a parse error, can you double check? |
mixonic
force-pushed
the
feature-flags
branch
4 times, most recently
from
cd24ad2 to
24dbb76
Compare
|
Blocked on ember-cli/babel-plugin-debug-macros#30 |
|
@mixonic - ember-cli/babel-plugin-debug-macros#30 is merged and published, can you update versions here to kick off CI again? |
|
@rwjblue this is good to go! |
|
❤️ |
2 participants
Add infrastructure for feature flags. This change should have no impact on applications currently consuming Ember-resolver. A PR to follow will add an initial implementation of the module unification feature behind this tooling.