Skip to content

Pass Referrer to Glimmer Resolver#196

Closed
iezer wants to merge 2 commits intoember-cli:masterfrom
201-created:isaac/pass-referrer
Closed

Pass Referrer to Glimmer Resolver#196
iezer wants to merge 2 commits intoember-cli:masterfrom
201-created:isaac/pass-referrer

Conversation

@iezer
Copy link
Contributor

@iezer iezer commented Jun 23, 2017

Changes required for local lookup

  • pass referrer to glimmer resolver
  • normalize input so that referrer is always absolute
  • add private collections to config.

Related PRs:

let appName = this.config.app.name;
let parts = referrer.split(':src/ui/');
referrer = `${parts[0]}:/${appName}/${parts[1]}`;
referrer = referrer.split('/template.hbs')[0];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An aside, but @dgeb thinks @wycats and @chancancode are perhaps working on adding the absolute specifier to the template meta a compilation time. One that work lands we could change Ember to pass that and this code goes away 👍

@mixonic
Copy link
Member

mixonic commented Jul 2, 2017

Closed in #198

@mixonic mixonic closed this Jul 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants