Merged
Conversation
Member
|
The floating dep tests are failing for:
tldr; we need to either downgrade to ember-source@3.12 or upgrade to 3.16 (to get emberjs/ember.js#18831) |
Contributor
Author
|
I'd prefer upgrading to 3.16. What would be your preference? |
Member
Yep, totally agree! I was just trying to help / point out what was going on... |
Contributor
Author
|
Can we merge this? :) |
rwjblue
approved these changes
Apr 11, 2020
Contributor
Author
|
🎉 |
rwjblue
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 8 reached its EOL and dependencies that stopped supporting it are now causing CI failures: #531 (comment)
This PR drops support for Node 8 and upgrades
ember-sourcefrom~3.14.3to~3.16.5to combat emberjs/ember.js#18831.