Remove container-debug-adapter initializer#904
Merged
Conversation
The initializer was used solely to register
`container-debug-adapter:main`, however simply **putting** the file into
`app/container-debug-adapter.js` will enable
`owner.lookup('container-debug-adapter:main')` to "just work".
🔥🔥🔥Initializers suck and should die in a fire. 🔥🔥🔥
rwjblue
force-pushed
the
remove-initializer
branch
from
738c61f to
283305f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initializer was used solely to register
container-debug-adapter:main, however simply putting the file intoapp/container-debug-adapter.jswill enableowner.lookup('container-debug-adapter:main')to "just work".🔥🔥🔥Initializers suck and should die in a fire. 🔥🔥🔥