Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates an alternative way to give the resolver access to your modules.
export default class App extends Application { modulePrefix = config.modulePrefix; - Resolver = Resolver; + Resolver = Resolver.withModules(modulesGoHere) }It expects a POJO with string keys and instantiated modules as values. It's intentionally eager to keep the rest of the public resolver API the same while being compatible with real ES module systems. An example of how you'd get the
modulesGoHerevalue is to derive it fromimport.meta.glob(..., { eager: true })or to use a virtual backward-compatibility set of modules provided by embroider.When you use
withModules, the resolver will not attempt to touchrequireorrequirejs, meaning your app can function entirely without an AMD loader.