Skip to content
This repository was archived by the owner on Jan 20, 2019. It is now read-only.

Multiple Build Targets#93

Closed
kratiahuja wants to merge 1 commit intoember-cli:masterfrom
kratiahuja:serve
Closed

Multiple Build Targets#93
kratiahuja wants to merge 1 commit intoember-cli:masterfrom
kratiahuja:serve

Conversation

@kratiahuja
Copy link
Contributor

@kratiahuja kratiahuja commented Jan 6, 2017

Rendered

Due to branching issues, this is a reopen of RFC #75.

@nathanhammond nathanhammond changed the title Build targets RFC reopen Multiple Build Targets Jan 6, 2017
@les2
Copy link

les2 commented Jan 21, 2017

@kratiahuja I have a suggestion for your consideration.

Suggestion: Place all targets under a common targets/ folder (or ember-cli-targets if targets/ is likely to cause problems with existing project layouts).

This would offer the following benefits:

  1. Group all the targets logically together (except for the default target, which isn't part of the targets hierarchy).
  2. Keep target names from conflicting with other folder names
  3. Allow auto-discovery of targets by ember-cli.

Example:

targets/
    |
    |-- fastboot/
    |
    |-- mobile/
    |
    |-- electron/
    |
    |-- roku/

@les2
Copy link

les2 commented Jan 21, 2017

Update to #93 (comment)

  • Custom environment.js config for a target could be located in the targets/$name/config/environment.js file. The inherited targets should be merged in and passed as the defaults parameter.

The ember g target command would create this file by default when generating the target.

@cibernox cibernox mentioned this pull request Feb 3, 2017
@rwjblue
Copy link
Member

rwjblue commented Jun 29, 2017

@kratiahuja - Where are we on this? Is this still a thing that we are going to try to push forward?

@kratiahuja
Copy link
Contributor Author

@rwjblue Not for FastBoot but I believe other platforms like electron could benefit from this. However, there is no strong usecase to build this at this time, so my recommendation is to not push forward with this.

@rwjblue
Copy link
Member

rwjblue commented Jan 19, 2019

We are working on closing the ember-cli/rfcs repo in favor of using a single central RFC's repo for everything. This was laid out in https://emberjs.github.io/rfcs/0300-rfc-process-update.html.

Sorry for the troubles, but would you mind reviewing to see if this is still something we need, and if so migrating this over to emberjs/rfcs?

Thank you!

@rwjblue rwjblue closed this Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants