Race condition prevents cleaning of dist folder between rebuilds

[jurecuhalev]

The first time I run a fastboot on a simple project, it works. Second time it crashes:

➜  moment-fastboot-example git:(master) NODE_DEBUG=fs ember fastboot --serve-assets
Installing FastBoot npm dependencies

Build successful - 12390ms.

Slowest Trees                                 | Total               
----------------------------------------------+---------------------
Babel                                         | 4257ms              
Babel                                         | 2892ms              
Babel                                         | 689ms               

Slowest Trees (cumulative)                    | Total (avg)         
----------------------------------------------+---------------------
Babel (30)                                    | 9917ms (330 ms)     

DEBUG: -------------------------------
DEBUG: Ember      : 2.7.0
DEBUG: Ember Data : 2.7.0
DEBUG: -------------------------------
Ember FastBoot running at http://[::]:3000
^C%                                                                                                                                                                                                                                                                          ➜  moment-fastboot-example git:(master) NODE_DEBUG=fs ember fastboot --serve-assets
Installing FastBoot npm dependencies

Build successful - 2498ms.

Slowest Trees                                 | Total               
----------------------------------------------+---------------------
SourceMapConcat: Concat: Vendor /assets/ve... | 135ms               

Slowest Trees (cumulative)                    | Total (avg)         
----------------------------------------------+---------------------
Babel (30)                                    | 678ms (22 ms)       
SourceMapConcat: Concat: Vendor /asset... (2) | 257ms (128 ms)      
JSHint templates (2)                          | 155ms (77 ms)       

fs.js:88
        throw backtrace;
        ^

Error: ENOTEMPTY: directory not empty, rmdir '/Users/gandalf/hacking/fastboot/moment-fastboot-example/dist/node_modules/moment/src/'
    at rethrow (fs.js:83:21)
    at maybeCallback (fs.js:101:42)
    at Object.fs.rmdir (fs.js:871:14)
    at TreeSync.<anonymous> (/Users/gandalf/hacking/fastboot/moment-fastboot-example/node_modules/tree-sync/index.js:79:19)
    at Array.forEach (native)
    at TreeSync.sync (/Users/gandalf/hacking/fastboot/moment-fastboot-example/node_modules/tree-sync/index.js:50:14)
    at CoreObject.module.exports.Task.extend.copyToOutputPath (/Users/gandalf/hacking/fastboot/moment-fastboot-example/node_modules/ember-cli/lib/models/builder.js:173:10)
    at /Users/gandalf/hacking/fastboot/moment-fastboot-example/node_modules/ember-cli/lib/models/builder.js:187:21
    at lib$rsvp$$internal$$tryCatch (/Users/gandalf/hacking/fastboot/moment-fastboot-example/node_modules/rsvp/dist/rsvp.js:493:16)
    at lib$rsvp$$internal$$invokeCallback (/Users/gandalf/hacking/fastboot/moment-fastboot-example/node_modules/rsvp/dist/rsvp.js:505:17)

Repository that I used to test: https://github.com/gandalfar/moment-fastboot-example

➜  moment-fastboot-example git:(master) ember -v
ember-cli: 2.7.0
node: 6.2.1
os: darwin x64

Connected ticket with a bit more discussion: jasonmit/ember-cli-moment-shim#55

[jurecuhalev]

In addition to that, if I remove dist so it would get regenerated, it fails to regenerated it correctly. It works correctly with ember s.

➜  moment-fastboot-example git:(master) rm -rf dist                  
➜  moment-fastboot-example git:(master) ember fastboot --serve-assets
Installing FastBoot npm dependencies

Build successful - 2703ms.

Slowest Trees                                 | Total               
----------------------------------------------+---------------------
SourceMapConcat: Concat: Vendor /assets/ve... | 135ms               

Slowest Trees (cumulative)                    | Total (avg)         
----------------------------------------------+---------------------
Babel (30)                                    | 728ms (24 ms)       
SourceMapConcat: Concat: Vendor /asset... (2) | 269ms (134 ms)      
JSHint templates (2)                          | 204ms (102 ms)      

There was an error trying to run your application in FastBoot.

This is usually caused by either your application code or an addon trying to access an API that isn't available in Node.js.
Based on the stack trace, it looks like the exception was generated in util.js on line 1007.
The exception is probably coming from your app. Look at this file and line number to determine what is triggering the exception.

The full stack trace is:

spawn /bin/sh ENOENT
Error: spawn /bin/sh ENOENT
    at exports._errnoException (util.js:1007:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:182:32)
    at onErrorNT (internal/child_process.js:348:16)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)

[jurecuhalev]

Running ember s also fixes fastboot. So that it runs once correctly again.

[Jarred-Sumner]

I'm running into this issue too.

[josemarluedke]

I'm also running into this issue.

[alidcast]

Is this fixed yet? I also ran into the couldn't find package.json issue. I ran ember build and tried again, and now I'm getting an document is not defined error.

[ptomasroos]

I'm having the same problem

[marcemira]

Hello, same here! 👋

[bigredwill]

There is a fix by @danmcclain #269 github.com/ember-fastboot/ember-cli-fastboot/pull/269

I tested it out and it solves this issue 😄

[stefanpenner]

I believe the root cause is, the fastboot server incorrectly serves from dist not from the output of the build. Note, dist is merely a user friendly reflection of the last build (be that test or build or server or ...).

the following would most likely address this issue: #274

and concretely, not having node_modules in dist would also mitigate (atleast the exact failure) #269

[danmcclain]

My fix is also temporary until the solution in #274 lands. 274 is the Way of the Future™

[stefanpenner]

@danmcclain i believe both are complementary.