Update README with new ember s instructions and build hooks.#399
Merged
kratiahuja merged 1 commit intoember-fastboot:masterfrom May 23, 2017
kratiahuja:update-readme
Merged
Update README with new ember s instructions and build hooks.#399kratiahuja merged 1 commit intoember-fastboot:masterfrom kratiahuja:update-readme
ember s instructions and build hooks.#399kratiahuja merged 1 commit intoember-fastboot:masterfrom
kratiahuja:update-readme
Conversation
| treeForVendor(defaultTree) { | ||
| var browserVendorLib = new Funnel(...); | ||
|
|
||
| browserVendorLib = map(browserVendorLib, (content) => `if (typeof FastBoot === 'undefined') { ${content} }`); |
Contributor
There was a problem hiding this comment.
should we tell people to just send the files to a different outputFile and have that included as part of the fastboot manifest? or.. ?
Contributor
Author
There was a problem hiding this comment.
I think this is for including the browser assets. FastBoot manifest is for the fastboot environment which works for the other usecase listed here: https://gist.github.com/kratiahuja/d22de0fb1660cf0ef58f07a6bcbf1a1c#using-processenvember_cli_fastboot-to-run-import-in-fastboot-build
stefanpenner
approved these changes
May 21, 2017
Contributor
Author
|
@stefanpenner good to merge? |
Contributor
Author
|
Merging this.. |
ro0gr
reviewed
May 23, 2017
| If your app is running `ember-cli` 2.12.0-beta.1+ you can run as follows: | ||
|
|
||
| * `ember serve` | ||
| * Visit your app at `http://localhost:42000` |
Contributor
Author
There was a problem hiding this comment.
sorry it should be 4200. mind sending a PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparing for FastBoot 1.0.
ember fastbootis now marked as deprecated.Fixes one issue listed in #396.
cc: @stefanpenner @tomdale