Skip to content

Comments

remove global flag.#418

Merged
kratiahuja merged 1 commit intomasterfrom
remove-global-flag
Jun 8, 2017
Merged

remove global flag.#418
kratiahuja merged 1 commit intomasterfrom
remove-global-flag

Conversation

@stefanpenner
Copy link
Contributor

Addons can check via:

this.project.addons.find(addon => addon.name === 'ember-cli-fastboot'):
this.project.findAddonByName('ember-cli-fastboot');

Addons can check via:

this.project.addons.find(addon => addon.name === 'ember-cli-fastboot'):
this.project.findAddonByName('ember-cli-fastboot');
@kratiahuja
Copy link
Contributor

This was introduced for a corner usecase for ember-cli-head to be backward compatible: https://github.com/ronco/ember-cli-head/blob/master/index.js#L13

@kratiahuja
Copy link
Contributor

Though now that I think about it, this flag would not be needed if treeForApp in ember-cli-head is refactored.

@stefanpenner
Copy link
Contributor Author

@stefanpenner
Copy link
Contributor Author

@kratiahuja ah, that would be even better. But if we need to check explicit things, (like capability) a version check may be more appropriate then a global flag.

But if it can be refactored away entirely, we should take that approach.

@kratiahuja
Copy link
Contributor

Yeah I don't think we need the if..else really...

@kratiahuja kratiahuja merged commit d2959d4 into master Jun 8, 2017
@kellyselden kellyselden deleted the remove-global-flag branch June 8, 2017 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants